Update BillingBlock.tpl - Error with CiviDiscount + Patch Issue #24781

[GreysonStalcup]

Fixes a bug where @count is an expecting an array to count but may not be given one in every case. when using CiviDiscount with the patch from issue #24781

Overview

An error, introduced when using the Stripe payment processor along with multi-participant registration, was fixed with a patch moving the payment block to the review page. However, this, when mixed with CiviDiscount, caused an error with the BillingBlock.tpl file. This simple addition checks to see if the variable is set before attempting to count it.

Before

Immediately begins to check $paymentFields|@count & $billingDetailFields|@count.

After

Checks the validity of $paymentFields -> proceeds to $paymentFields|@count || same with $billingDetailFields -> moves to $billingDetailFields|@count.

Technical Details

Minimal change, prevents an error being thrown and TPL breaking when the discount button is clicked.

Comments

This has to do with the issue: issue #24781

[civicrm-builder]

Can one of the admins verify this patch?

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@GreysonStalcup I think an even more minimal fix here would be to simply remove the |@count as it's meaningless in the context of an if statement. Empty arrays are already equivalent to false, so counting them does nothing.

[GreysonStalcup]

@GreysonStalcup I think an even more minimal fix here would be to simply remove the |@count as it's meaningless in the context of an if statement. Empty arrays are already equivalent to false, so counting them does nothing.

@colemanw I think that makes total sense. I added a new commit to this PR without the @count, just checking for the existence of those variables. Should have done that to begin with honestly. Apologies, I am not the best with smarty 😅

[colemanw]

Ok great. FYI in the future you can do git commit --amend and git push -f to keep your PR to a single commit.
But it's still fixable, you can do git rebase -i HEAD~2 and put s on the 2nd line. Then when the 2 commits are squashed you can get push -f and the PR will be nice & clean :)

[colemanw]

@civicrm-builder add to whitelist

[colemanw]

Great, thanks @GreysonStalcup for working on this!