Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#4226 Add labelField metadata for mapping entity #26046

Merged
merged 1 commit into from
Apr 11, 2023
Merged

dev/core#4226 Add labelField metadata for mapping entity #26046

merged 1 commit into from
Apr 11, 2023

Conversation

colemanw
Copy link
Member

Overview

Fixes dev/core#4226 by adding missing metadata.

@civibot
Copy link

civibot bot commented Apr 11, 2023

(Standard links)

@civibot civibot bot added the master label Apr 11, 2023
@eileenmcnaughton eileenmcnaughton changed the title Add labelField metadata for mapping entities dev/core#4226 Add labelField metadata for mapping entities Apr 11, 2023
@eileenmcnaughton
Copy link
Contributor

@colemanw this works in the explorer but when I try to use in a managed enity it fails...

image

I would merge at least this part but name in MappingField should not be identified as a name column - it is really field_name & is not even unique within one mapping.... so I think we need to stick to the change on the Mapping entity

@colemanw colemanw changed the title dev/core#4226 Add labelField metadata for mapping entities dev/core#4226 Add labelField metadata for mapping entity Apr 11, 2023
@colemanw colemanw merged commit 2d28c12 into civicrm:master Apr 11, 2023
@colemanw colemanw deleted the mappingLabel branch April 11, 2023 21:34
wmfgerrit pushed a commit to wikimedia/wikimedia-fundraising-crm that referenced this pull request Apr 17, 2023
@eileenmcnaughton @ejegg
Add import templates
989e075 
This creates a couple of initial templates in line with what
Melanie & I have been testing. I figure it will save re-creating on
live & also help us to test in future

Also included is a sample data file for us to use while testing

Includes civicrm/civicrm-core#26046
and civicrm/civicrm-core#26055

Bug: T303986

Change-Id: I91490eaa537d454d79f244a0a008264f513ce2d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton