Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Symfony Service Contracts to 2.2.0 to fix php fatal error i… #24171

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

seamuslee001
Copy link
Contributor

…n wordpress

Overview

5.53/master version of #24170

ping @eileenmcnaughton @demeritcowboy @kcristiano @totten

@civibot
Copy link

civibot bot commented Aug 7, 2022

(Standard links)

@civibot civibot bot added the master label Aug 7, 2022
@demeritcowboy
Copy link
Contributor

Thanks @seamuslee001.
Let me check if this causes a problem with drupal 9 - we could maybe do one of those || ~ things if so.

@demeritcowboy
Copy link
Contributor

I get these errors in drupal 9:

  • drupal/core-recommended 9.4.5 requires psr/container ~1.1.1
  • drupal/core-recommended 9.4.5 requires symfony/service-contracts ~v2.5.1

@seamuslee001
Copy link
Contributor Author

@demeritcowboy I think this should be sorted now i.e. it should install v2.2.0 in the tarballs but permit d9 installing

@demeritcowboy
Copy link
Contributor

Ok for me.
@kcristiano does this solve the original problem (if you replace these files and run composer install - but not the ones here the ones from the 5.52 PR since the .lock is different)

@kcristiano
Copy link
Member

#24170 (comment)

@kcristiano
Copy link
Member

I just did a new build of master (5.53-alpha) and upgraded to that version follwing the steps in the above comment. this PR looks good as well.

Looks good to merge

@demeritcowboy
Copy link
Contributor

@seamuslee001 I can't upmerge 5.52 since there's conflicts and merging this will make more conflicts. Hopefully will get sorted out as part of the 5.53 branching?

@seamuslee001
Copy link
Contributor Author

@demeritcowboy at the moment there is no 5.53 branch so master = 5.53 branch = RC effectively at the moment hence why I did 2 PRs

@seamuslee001 seamuslee001 merged commit 89fa7d7 into civicrm:master Aug 7, 2022
@seamuslee001 seamuslee001 deleted the dev_core_3781_master branch August 7, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants