Improve test readability, use schema labels for membership tokens #21708
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
test_clean
branch
2 times, most recently
from
6cc385a to
a59d113
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
test_clean
branch
from
a59d113 to
4ef5e48
Compare
eileenmcnaughton
force-pushed
the
test_clean
branch
from
4ef5e48 to
044c0ad
Compare
|
test this please |
|
@colemanw @demeritcowboy can I get a merge on this - it changes tests for readability but has a lot of 'noise' |
|
I think this is ok. This is the only place this comes up right?
|
| ' . CRM_Utils_Date::customFormat($this->case['modified_date']) . ' | ||
| return 'case.id :1 | ||
| case.case_type_id:label :Housing Support | ||
| case.subject :Case Subject |
There was a problem hiding this comment.
The colon spacing seems odd but not a blocker. I can see that if the token contains a colon it would look just as weird to have it stuck to the left side. Maybe some other character? e.g. case.case_type_id:label | Housing Support
There was a problem hiding this comment.
@demeritcowboy no - you have no idea how much pain it took to get to this point - please don't make me change it
There was a problem hiding this comment.
also fyi I originaly had a space either side of the : - what happened was the IDE kept stripping it & I spent hours staring at strings to figure out how they were different
|
@demeritcowboy yep re the member label |
Overview
Improve test readability, use schema labels for membership tokens
Before
After
above are fixed
Technical Details
You could argue whether the schema labels or the hard-coded labels are more intuitive but I think that question should be phrased as 'should the schema labels be updated' rather than what is being addressed here 'should the labels match the schema titles for the fields'
Comments