SearchKit - A random stable genius #21586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
SearchKit allows ORDER BY RAND() but this can cause unexpected reshuffling when using the pager, editing-in-place or bulk-updating records. The solution is to generate a seed on the client-side when the display initializes, and re-use it every time results are fetched. This keeps the order stable, only reshuffling when the browser reloads the page.
colemanw
force-pushed
the
stableRandom
branch
from
4ae33b9 to
2eee385
Compare
|
Seems to work - re-randomises on refresh but if I page back to the start it keeps the sort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows the pager, edit-in-place, and bulk updates to work properly with random sorting.
Before
You can do this, but it will cause strange behavior with the pager and inline/bulk updates. Results will appear randomly on each page, making the pager unusable, and a record will "disappear" immediately after inline-editing because it gets shuffled to a different spot.
After
Works as expected.
Technical Details
Without a seed,
ORDER BY RAND()will reshuffle the results every time, whereas searchkit expects a stable order.The solution is to generate a seed on the client-side when the display initializes, and re-use it every time results are fetched. This keeps the order stable, only reshuffling when the browser reloads the page.