flushCaches should respect permitCacheFlushMode

[mattwire]

Overview

There is an option to prevent cache flushes CRM_Core_Config::isPermitCacheFlushMode() (currently only used by the importer) but it's only respected if we flush caches via the CRM_Contact_BAO_Contact_Utils::clearContactCaches() function which is bypassed by both opportunistic and deterministic (group contact) cache flushes. This means it's quite likely caches will be flushed anyway probably triggering deadlocks.

Before

Group contact cache flushed even if CRM_Core_Config::isPermitCacheFlushMode() returns FALSE when opportunistic/deterministic cache flush is triggered.

After

Group contact cache not flushed if CRM_Core_Config::isPermitCacheFlushMode() returns FALSE when opportunistic/deterministic cache flush is triggered.

Technical Details

Comments

@eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).