dev/core#2814 migrate export processor to use MessageRender

[eileenmcnaughton]

Overview

dev/core#2814 migrate export processor to use MessageRender

Before

replaceContactTokens used

After

MessageRender used

Technical Details

Note that test cover is in CRM_Export_BAO_ExportTest

I used testMergeSameAddressGreetingOptions to step through it
as that specifically covers this change. In this case the cover is tightly correlated enough to make an r-run redundant

Comments

https://lab.civicrm.org/dev/core/-/issues/2814

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I thought I fixed this test but I think I know what the second problem is.

CRM_Utils_TokenConsistencyTest::testCaseTokenConsistency
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 Ongoing\n
 No\n
 2021-09-04 06:22:17\n
-2021-09-04 06:22:17\n
+2021-09-04 06:22:18\n
 '

/home/jenkins/bknix-dfl/build/core-21367-7xmdz/web/sites/all/modules/civicrm/tests/phpunit/CRM/Utils/TokenConsistencyTest.php:57

jenkins retest this please

[eileenmcnaughton]

test this please

[colemanw]

I agree test coverage is sufficient to make this a safe change.