Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Switch to using shared function to call deprecated function #19246

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code consolidation

Before

Other import places call a function on the class but this instance still calling the deprecated function directly

After

Class calling function on parent

Technical Details

With this done all the functionality in the deprecated function can be moved into the shared function

Comments

With this done all the functionality in the deprecated function can be moved into the shared function
@civibot
Copy link

civibot bot commented Dec 21, 2020

(Standard links)

@civibot civibot bot added the master label Dec 21, 2020
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 are you OK to merge this one ? It will allow me to move the function out of deprecated utils when only 1 place calls it

@seamuslee001
Copy link
Contributor

This looks fine to me merging

@seamuslee001 seamuslee001 merged commit 27f2675 into civicrm:master Dec 21, 2020
@seamuslee001 seamuslee001 deleted the import branch December 21, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants