Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Remove skip that seems no longer required #16912

Merged
merged 1 commit into from
Mar 30, 2020
Merged

[Test] Remove skip that seems no longer required #16912

merged 1 commit into from
Mar 30, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Slight tightening of apiv4 testing

Before

Lines to avoid fail on hitting deprecation

After

Lines removed as no longer required

Technical Details

I expect these lines were added to get past fails when introducing the test without having to deal with every issue encountered but they seem no longer required

Comments

@eileenmcnaughton
[Test] Remove skip that seems no longer required
5acc618 
The removed line seems to be loosening the test for a deprecation that I didn't hit in testing today
@civibot
Copy link

civibot bot commented Mar 26, 2020

(Standard links)

@civibot civibot bot added the master label Mar 26, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@mattwire mattwire merged commit 37aec4d into civicrm:master Mar 30, 2020
@eileenmcnaughton eileenmcnaughton deleted the conf_2 branch March 30, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @mattwire