[REF] Remove redundant call to build permissions

[eileenmcnaughton]

Overview

Per the comments I added to the function the output of this permissions clause is overwritten. I stepped through
this in the process of reviewing the datepicker PR & confirmed it

Before

Override postProcess function calls $this->buildACLClause($this->_aliases['civicrm_contact']); but I have confirmed the results of that are overwritten

After

Poof

Technical Details

@seamuslee001 @monishdeb @yashodha @MegaphoneJon - I think we have suspected these fn calls were obsolete for a while but I can now confirm that any form that calls buildACLClause and then calls parent::postProcess will have the output of buildACLClause ovewritten

parent::postProcess calls
$sql = $this->buildQuery(); which calls
$this->buildPermissionClause();
which does

    // Override output from buildACLClause
    $this->_aclFrom = NULL;
    $this->_aclWhere = implode(' AND ', $ret);

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

I simply agree because of this backtrace

parent::postProcess calls
$sql = $this->buildQuery(); which calls
$this->buildPermissionClause();

which overrides the $this->buildACLClause($this->_aliases['civicrm_contact']);
call in postprocess so why should we have this line in postprocess in first place, oops then why should we override postprocess, yeah lets remove it and put merge on pass on this PR.

Which I did :)

[eileenmcnaughton]

@monishdeb lol - yeah I've suspected for a while those can go but this is the first time I've confirmed it