Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test cleanup #16817

Merged
merged 1 commit into from
Mar 17, 2020
Merged

[NFC] Test cleanup #16817

merged 1 commit into from
Mar 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix some comment blocks, remove some unused variables

Before

Variables declared but unused, wrong or missing exceptions declaration

After

fixed

Technical Details

Comments

Not the whole file done...

@eileenmcnaughton
[NFC] Test cleanup
79312d3 
Fix some comment blocks, remove some unused variables
@civibot
Copy link

civibot bot commented Mar 17, 2020

(Standard links)

@civibot civibot bot added the master label Mar 17, 2020
@seamuslee001
Copy link
Contributor

Looks fine to me and Jenkins is happy with it

@seamuslee001 seamuslee001 merged commit 0c8e891 into civicrm:master Mar 17, 2020
@seamuslee001 seamuslee001 deleted the deltest branch March 17, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001