Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recurring contribution ID to doCancelRecurring #16741

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Mar 10, 2020

Overview

Add the most useful parameter to the propertybag - the ID of the recurring contribution.

Before

Only subscriptionID (processorID) available.

After

processorID + recurID available.

Technical Details

Just add to propertybag - the ID is always available on the form parameters.

Comments

@eileenmcnaughton @artfulrobot

@civibot
Copy link

civibot bot commented Mar 10, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I pulled this down locally & did the same refactor & was able to reach the same result.

I agree with the extra parameter

@eileenmcnaughton
Copy link
Contributor

@mattwire I've removed the MOP - only because the first commit can be rebased out - once that is done it's MOP

@artfulrobot
Copy link
Contributor

This looks good to me too, thanks @mattwire

@mattwire
Copy link
Contributor Author

Thanks @eileenmcnaughton @artfulrobot rebased and added MOP

@seamuslee001 seamuslee001 merged commit 3bfb312 into civicrm:master Mar 11, 2020
@mattwire mattwire deleted the addrecurid2 branch June 24, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants