[REF] Pass params into function rather than this weird check for whether params exists. #16438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her params exists. This function used to be shared with the online form & hence this form had to work to make itself 'look' like the other form. It is now free to be it's own form
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
ev_clean
branch
from
3a84c36 to
b2a8013
Compare
|
test this please |
|
@seamuslee001 it's passed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code tidy up = This function used to be shared with the online form & hence this form had to work to make itself 'look' like the other form.
It is now free to be it's own form
Before
form does a weird check for $this->_params & then assigns them to params
After
we just pass them in as params
Technical Details
Comments
Anything else you would like the reviewer to note