Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove function that exactly matches parent class. #16316

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Remove function that exactly matches parent class. #16316

merged 1 commit into from
Jan 18, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Removes override function that matches parent

Before

Same function exists in child & parent

After

I moved it over onto the parent class fn & apart from minor comment block differences it matches.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 17, 2020

(Standard links)

@civibot civibot bot added the master label Jan 17, 2020
colemanw
colemanw reviewed Jan 17, 2020
View reviewed changes
@eileenmcnaughton
Remove function that exactly matches parent class.
f14a62d 
I copied it over the parent class fn & apart from minor comment block differences it matches
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

retest this please

@seamuslee001 seamuslee001 merged commit 3ecd083 into civicrm:master Jan 18, 2020
@seamuslee001 seamuslee001 deleted the parent branch January 18, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @colemanw @seamuslee001