Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] rename lineItem & lineItems variable #16254

Merged
merged 1 commit into from
Jan 9, 2020
Merged

[REF] rename lineItem & lineItems variable #16254

merged 1 commit into from
Jan 9, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Rename variables for clarity

Before

$lineItem refers to an array of lineItems, $lineItems refers to a single (created) lineItem

After

$lineItems refers to an array of line items, $createdLineItem refers to the single (created) line item

Technical Details

Comments

@eileenmcnaughton
[REF] rename lineItem & lineItems variable
19d97a6 
Readability fix -

=======Before========
 refers to an array of lineItems,  refers to a single lineItem

=======After
 refers to an array of line items,  refers to the single (created) line itmem
@civibot
Copy link

civibot bot commented Jan 9, 2020

(Standard links)

@civibot civibot bot added the master label Jan 9, 2020
@mattwire mattwire merged commit a6d3950 into civicrm:master Jan 9, 2020
@eileenmcnaughton eileenmcnaughton deleted the partial_pay branch January 9, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @mattwire