Remove $ids as parameter for Membership::add

[eileenmcnaughton]

Overview

Removes $ids from Membership::add signature

Before

 public static function add(&$params) {

After

 public static function add(&$params, $ids = []) {

Technical Details

The only place it's called with is from create so we can handle userId there

Comments

We decided a very long time ago to get rid of the $ids pattern as it was not consistent enough to use

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 @mattwire we can finally remove $ids from add now...

[seamuslee001]

Looks good to me

[eileenmcnaughton]

@seamuslee001 & from the code comments I can see another step

          // @todo stop passing empty $ids
          CRM_Member_BAO_Membership::create($params, $ids);

:-)