Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] remove as a return Param of getHierContactDetails #15714

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor cleanup of unused variable

Before

$options returned but never used

After

$options not returned

Technical Details

In trying to get to the bottom of BAO_CustomQuery I hit confusion about whether options should still exist.

This removes it from the return values of getHierContactDetails, making for a cleaner later PR when
we can check all calls to CRM_Contact_BAO_Query::apiQuery use the 'list' construct and only
use one param - at which point we can pull it out of apiQuery

Comments

In trying to get to the bottom of BAO_CustomQuery I hit confusion about whether options should still exist.

This removes it from the return values of getHierContactDetails, making for a cleaner later PR when
we can check all calls to CRM_Contact_BAO_Query::apiQuery use the 'list' construct and only
use one param - at which point we can pull it out of apiQuery
@civibot
Copy link

civibot bot commented Nov 3, 2019

(Standard links)

@civibot civibot bot added the master label Nov 3, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

Makes sense to me merging

@seamuslee001 seamuslee001 merged commit 1a18739 into civicrm:master Nov 4, 2019
@seamuslee001 seamuslee001 deleted the custom_sane_save branch November 4, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants