Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] various code cleanup on CRM_Contact_BAO_Query #15713

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup

Before

Code less stdised

After

Code more stdised

Technical Details

Fix comment blocks, correct parameter types in blocks etc, fix some miscased fn calls, add throws tags
use strict comparison when comparing with strings

Comments

@civibot
Copy link

civibot bot commented Nov 3, 2019

(Standard links)

Fix comment blocks, correct parameter types in blocks etc, fix some miscased fn calls, add throws tags
use strict comparision when comparing with strings
@seamuslee001
Copy link
Contributor

Looks fine to me reviewed it all and i'm confident we have solid test coverage in this area merge on pass

@seamuslee001 seamuslee001 merged commit 77d898a into civicrm:master Nov 4, 2019
@seamuslee001 seamuslee001 deleted the query_clean branch November 4, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants