dev/core#560 Convert some more CRM_Core_Error::fatal to exception #15608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Switch from statusBounce to Exception in CRM_Mailing_BAO_Mailing::checkPermission as not on form layer
seamuslee001
force-pushed
the
more_fatal_exception
branch
from
7fa4001 to
2a7b822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This converts some more usages of CRM_Core_Error::fatal to relevant Exception throwing or statusBounce calling
Before
Deprecated CRM_Core_Error::fatal is used
After
Modern Error handling methods are used
ping @eileenmcnaughton @mattwire @totten