dev/financial#72 Filter contribution status dropdowns in search and report #15470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
ejegg
force-pushed
the
filterContribStatus
branch
5 times, most recently
from
60f3434 to
9228c02
Compare
Replacing pseudoConstant calls with BAO buildOptions in 'search' context. This commit is only intended to touch places where we are building a list of options to offer to the user, not places where we are displaying results. In practice this doesn't remove any currently available statuses, but now we can filter our the proposed 'Template' status.
ejegg
force-pushed
the
filterContribStatus
branch
from
9228c02 to
c0aaecf
Compare
ejegg
changed the title
|
Thanks @ejegg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing pseudoConstant calls. In search and reporting, use BAO
buildOptions with 'search' context.
This commit is only intended to touch places where we are building
a list of options to offer to the user, not places where we are
displaying results.
Overview
Uses a higher-level function to create the options for the Contribution Status dropdowns so that we can filter by context.
Before
Contribution Status dropdowns will show all statuses, regardless of whether they make sense.
After
Contribution Status dropdowns are filtered to the appropriate context. For search and reporting, all existing statuses are still displayed, but the proposed 'Template' status can be easily filtered out.
Technical Details
Comments
Anything else you would like the reviewer to note