#1253 Pass mailing id to alterMailContent hook

[bhahumanists]

https://lab.civicrm.org/dev/core/issues/1253

Overview

Passes through the mailing ID to alterMailContent hook

Before

The hook can't figure out anything about the mailing that the content is part of.

After

The hook has access to data about the mailing that the content is part of.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

This seems like a good idea.

I double-checked (by reading code) to see if this would be provided consistently in different cases where h_c_alterMailContent fires:

• 👍 Traditional BAO mailer and Flexmailer both load templates through CRM_Mailing_BAO_Mailing::getTemplates(), so it should fire the same way in either case.
• ⚠️ CRM_Core_BAO_MessageTemplate also fires h_c_alterMailContent. The mailingID wouldn't make sense in that case.

It would make sense to update the docs (https://github.com/civicrm/civicrm-dev-docs/blob/master/docs/hooks/hook_civicrm_alterMailContent.md) to indicate that mailingID and messageTemplateID are only provided under certain circumstances.

[mattwire]

@bhahumanists Please can you create a docs PR https://github.com/civicrm/civicrm-dev-docs/pulls and then link to it here. Once that's done we can merge this PR.

[bhahumanists]

Done: civicrm/civicrm-dev-docs#703

[homotechsual]

Docs PR is approved for merge with core release.

[homotechsual]

@mattwire you can remove needs-documentation label from this - docs PR is good to go.