PHP warnings on Case Dashboard and Find Cases #13998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#13746 adds a formRule() to CRM_Core_Form_Search, but CRM_Case_Form_Search is derived from that class and already has one that doesn't match.
Before
Warning: Declaration of CRM_Case_Form_Search::formRule($fields) should be compatible with CRM_Core_Form_Search::formRule($fields, $files, $form) in require_once() (line 37 of CRM\Case\Form\Search.php).
After
All good.