Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP warnings on Case Dashboard and Find Cases #13998

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

demeritcowboy
Copy link
Contributor

Overview

#13746 adds a formRule() to CRM_Core_Form_Search, but CRM_Case_Form_Search is derived from that class and already has one that doesn't match.

Before

Warning: Declaration of CRM_Case_Form_Search::formRule($fields) should be compatible with CRM_Core_Form_Search::formRule($fields, $files, $form) in require_once() (line 37 of CRM\Case\Form\Search.php).

After

All good.

@civibot
Copy link

civibot bot commented Apr 8, 2019

(Standard links)

@civibot civibot bot added the master label Apr 8, 2019
@demeritcowboy demeritcowboy changed the title PHP warnings on Case Dashboard and Case Search PHP warnings on Case Dashboard and Find Cases Apr 8, 2019
@seamuslee001
Copy link
Contributor

Looks fine to me merge on pass

@seamuslee001
Copy link
Contributor

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 1a4911e into civicrm:master Apr 8, 2019
@demeritcowboy demeritcowboy deleted the fix-formRule branch April 9, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants