Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fix #13949

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Test fix #13949

merged 1 commit into from
Apr 3, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Test fix on logging test

Before

More false fails

After

Less false fails

Technical Details

Logging requires our servers to be slow enough that the actions happen at least one second apart. Performance improvements broke the test

Comments

@civibot
Copy link

civibot bot commented Apr 3, 2019

(Standard links)

@civibot civibot bot added the master label Apr 3, 2019
seamuslee001
seamuslee001 approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on pass Jenkins is the only real reviewer here

@eileenmcnaughton eileenmcnaughton merged commit 842f66f into civicrm:master Apr 3, 2019
@eileenmcnaughton eileenmcnaughton deleted the sleep branch April 3, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001