Use TempTable methods. #13880
Merged
Use TempTable methods. #13880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
temp_repeat
branch
from
abb9c33 to
0384322
Compare
|
Jenkins re test this please |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use the TempTable methods to create some more temporary tables.
Before
Various classes create temporary tables via raw SQL.
After
Use CRM_Utils_SQL_TempTable methods to create temporary tables. It should no longer be necessary to cleanup temporary tables in tests as they will have unique names.
This is a partial of #13819 - I found enough time today to review one report so merging as a reviewer's commit
Ping @mfb