Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Contact.create calls to respect passed in variables & variables set via hook for sort_name & display_name #13863

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a bug whereby Contact.create does not respect attempts to set sort_name & display_name via hook or as passed by the parameters

Before

sort_name set by hook is ignored

After

sort_name set by hook is respected

Technical Details

This has been applied to Organizations & Households, not Individuals at this stage as that is more complex.

Use case is saving organizations with The so that The is at the end of their sort_name, making it easier to
deal with data entry variations

Comments

@civibot
Copy link

civibot bot commented Mar 20, 2019

(Standard links)

@civibot civibot bot added the master label Mar 20, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the pre_test branch 2 times, most recently from bf7c932 to cb6fd90 Compare March 20, 2019 03:03
…et via hook for sort_name & display_name

This has been applied to Organizations & Households, not Individuals at this stage as that is more complex.

Use case is saving organizations with The so that The is at the end of their sort_name, making it easier to
deal with data entry variations
@eileenmcnaughton
Copy link
Contributor Author

test this please

@aydun
Copy link
Contributor

aydun commented Mar 25, 2019

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: Tested via API Contact.create with & without PR. display_name and sort_name set as expected
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@colemanw colemanw merged commit fa947b8 into civicrm:master Mar 25, 2019
@colemanw colemanw deleted the pre_test branch March 25, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants