Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cacheCode optional in CRM.loadScript #13824

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Make cacheCode optional in CRM.loadScript #13824

merged 1 commit into from
Mar 15, 2019

Conversation

colemanw
Copy link
Member

Overview

A cacheCode was recently added to script urls fetched by CRM.getScript(). This is not always desirable e.g. for scripts fetched from an external source, so now it's optional.

Before

Cachecode added unconditionally.

After

Cachecode added by default but can be disabled.

@civibot
Copy link

civibot bot commented Mar 14, 2019

(Standard links)

@civibot civibot bot added the master label Mar 14, 2019
@colemanw colemanw changed the base branch from master to 5.12 March 14, 2019 22:25
@civibot civibot bot added 5.12 and removed master labels Mar 14, 2019
@colemanw colemanw changed the base branch from 5.12 to master March 14, 2019 23:42
@civibot civibot bot added master and removed 5.12 labels Mar 14, 2019
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton merged commit c948e0f into civicrm:master Mar 15, 2019
@eileenmcnaughton eileenmcnaughton deleted the loadScriptCode branch March 15, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton