CRM-21216 Remove api limit, make deprecated function more deprecated #11029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschuettler
reviewed
Sep 26, 2017
| } | ||
| return $membershipTypes; | ||
| Civi::log()->warning('Deprecated function getMembershipTypesByOrg, please user membership_type api', array('civi.tag' => 'deprecated')); | ||
| $memberTypesSameParentOrg = civicrm_api3('MembershipType', 'get', array( |
There was a problem hiding this comment.
I think some copy & pasting did go wrong here. I think you wanted to paste this into: CRM_Member_Page_Tab::browse() and leave the to be deprecated function as it is.
There was a problem hiding this comment.
I think this is fine - it does the same thing as the previous function but in a way that is more clearly 'the same as the api'
|
I think there is one more location - CRM/Member/Page/Tab.php where the limit is an issue |
mattwire
force-pushed
the
CRM-21216_getMembershipTypesByOrg_to_api
branch
from
d8683f7 to
c8eada2
Compare
|
@eileenmcnaughton Thanks for spotting the file I missed... Now updated limits in all places! |
|
Looks good now - thanks @mattwire @tschuettler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes based on comments from previous PR #11020.
Assuming this passes tests it should be merged as the previous patch inadvertently introduces a limit on 25 membership types.
@eileenmcnaughton thanks for the previous merge. This one fixes the issues identified in comments.