CRM-21114: copy assignees on file on case #10912
Conversation
|
Jenkins retest this please |
|
Just tested this to confirm and saw no errors or red flags here. The previous functionality of setting to blank array doesn't make a lot of sense to me, either. Before - Both "move to case" from the "manage case" window and "file on case" from the "activities" tab caused the assignee to be dropped off of the activity. After - The assignee is transferred correctly when the activity is filed on a case or moved between cases. @colemanw can you take a look at merge please? |
|
Ah ok, no worries. I just left a comment that I can see here but maybe because I didn't finish my review it's not visible or something. Like I said, it's nothing too important, but just was surprised to see the merge notification. |
|
@mickadoo yeah... I don't see anything there. It must not be saved and exposed to others unless you finish the review. |
| // typically this will be empty, since assignees on another case may be completely different | ||
| $assigneeContacts = array(); | ||
| //CRM-21114 retrieve assignee contacts from original case; allow overriding from params | ||
| $assigneeContacts = CRM_Activity_BAO_ActivityContact::retrieveContactIdsByActivityId($params['activityID'], $assigneeID); |
There was a problem hiding this comment.
I'm not sure I follow here, from the method signature the second parameter is $recordTypeId, but you're passing in $assigneeID
Aside from that, the original comment suggested that leaving $assigneeContacts as empty was intentional, do you think copying them over will be expected behaviour for most cases?
There was a problem hiding this comment.
$assigneeID is the record type id -- see line 344. Not the greatest var name, but it was already there and referenced elsewhere in the function, so I didn't change it. Re: the original comment -- that was mentioned in the Jira ticket and @colemanw agreed we should copy the assignees. I think in normal usage, people would expect the assignee to be moved with the activity.
|
@lcdservices I found some relevant info
I'm sorry! I thought I'd commented and just nobody had replied 😄 |
Overview
When filing an activity on a case, also copy the original assignees.
Before
File on case would ignore existing activity assignees.
After
Assignees are now copied to the new activity in the case record.