more coverage

cityssm · Dec 4, 2023 · f678014 · f678014
1 parent 22ddde2
commit f678014
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 6 deletions.
diff --git a/formats/cpa005.js b/formats/cpa005.js
@@ -45,7 +45,7 @@ function validateTransactions(eftTransactions) {
             warningCount += 1;
         }
         if (transaction.segments.length > 6) {
-            debug('Transaction record has more than 6 segments, we be split into multiple transactions.');
+            debug('Transaction record has more than 6 segments, will be split into multiple transactions.');
             warningCount += 1;
         }
         if (!['C', 'D'].includes(transaction.recordType)) {

diff --git a/formats/cpa005.ts b/formats/cpa005.ts
@@ -69,15 +69,13 @@ function validateTransactions(eftTransactions: EFTTransaction[]): number {
 
     if (transaction.segments.length > 6) {
       debug(
-        'Transaction record has more than 6 segments, we be split into multiple transactions.'
+        'Transaction record has more than 6 segments, will be split into multiple transactions.'
       )
       warningCount += 1
     }
 
     if (!['C', 'D'].includes(transaction.recordType)) {
-      throw new Error(
-        `Unknown recordType: ${transaction.recordType}`
-      )
+      throw new Error(`Unknown recordType: ${transaction.recordType}`)
     }
 
     for (const segment of transaction.segments) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/test.js b/test/test.js
@@ -43,6 +43,34 @@ describe('eft-generator - CPA-005', () => {
         assert.ok(output.length > 0);
         assert.strictEqual(output.charAt(0), 'A');
     });
+    it('Throws error when originatorId length is too long.', () => {
+        const eftGenerator = new EFTGenerator({
+            originatorId: '12345678901234567890',
+            originatorLongName: '',
+            fileCreationNumber: '0001'
+        });
+        try {
+            eftGenerator.toCPA005();
+            assert.fail();
+        }
+        catch {
+            assert.ok(true);
+        }
+    });
+    it('Throws error when fileCreationNumber is invalid.', () => {
+        const eftGenerator = new EFTGenerator({
+            originatorId: '1',
+            originatorLongName: '',
+            fileCreationNumber: 'abcdefg'
+        });
+        try {
+            eftGenerator.toCPA005();
+            assert.fail();
+        }
+        catch {
+            assert.ok(true);
+        }
+    });
     it('Warns on missing originatorShortName', () => {
         const eftGenerator = new EFTGenerator({
             originatorId: '01',

diff --git a/test/test.ts b/test/test.ts
@@ -52,6 +52,36 @@ describe('eft-generator - CPA-005', () => {
     assert.strictEqual(output.charAt(0), 'A')
   })
 
+  it('Throws error when originatorId length is too long.', () => {
+    const eftGenerator = new EFTGenerator({
+      originatorId: '12345678901234567890',
+      originatorLongName: '',
+      fileCreationNumber: '0001'
+    })
+
+    try {
+      eftGenerator.toCPA005()
+      assert.fail()
+    } catch {
+      assert.ok(true)
+    }
+  })
+
+  it('Throws error when fileCreationNumber is invalid.', () => {
+    const eftGenerator = new EFTGenerator({
+      originatorId: '1',
+      originatorLongName: '',
+      fileCreationNumber: 'abcdefg'
+    })
+
+    try {
+      eftGenerator.toCPA005()
+      assert.fail()
+    } catch {
+      assert.ok(true)
+    }
+  })
+
   it('Warns on missing originatorShortName', () => {
     const eftGenerator = new EFTGenerator({
       originatorId: '01',