Use has_privs_of_role instead of is_member_of_role in UserHasPermissionToViewStatsOf()#7923
Draft
onurctirtir wants to merge 2 commits intomainfrom
Draft
Use has_privs_of_role instead of is_member_of_role in UserHasPermissionToViewStatsOf()#7923onurctirtir wants to merge 2 commits intomainfrom
onurctirtir wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7923 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 287 287
Lines 63136 63135 -1
Branches 7941 7941
=======================================
+ Hits 56163 56164 +1
+ Misses 4663 4662 -1
+ Partials 2310 2309 -1 🚀 New features to boost your workflow:
|
…onToViewStatsOf As of postgres/postgres@6198420, the usage of is_member_of_role is replaced by has_privs_of_role for pg_stat_activity, pg_stat_statements and many others.
onurctirtir
force-pushed
the
fix-priv-checks-for-stats
branch
from
f01b808 to
bfd8098
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of postgres/postgres@6198420, the usage of is_member_of_role is replaced by has_privs_of_role for pg_stat_activity, pg_stat_statements and many others.
TODO: Need to better understand the implications of this change and need to add a few tests.
DESCRIPTION: PR description that will go into the change log, up to 78 characters