Skip to content

PG17 compatibility: revert #7764 - #7775

Merged
Colm (colm-mchugh) merged 1 commit into
release-13.0from
cmchugh/pg17-revert-7253
Dec 3, 2024
Merged

PG17 compatibility: revert #7764#7775
Colm (colm-mchugh) merged 1 commit into
release-13.0from
cmchugh/pg17-revert-7253

Conversation

@colm-mchugh

@colm-mchugh Colm (colm-mchugh) commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Revert PG17 compatibility fix #7764

@codecov

codecov Bot commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-13.0@26c09f3). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             release-13.0    #7775   +/-   ##
===============================================
  Coverage                ?   89.63%           
===============================================
  Files                   ?      274           
  Lines                   ?    59582           
  Branches                ?     7436           
===============================================
  Hits                    ?    53409           
  Misses                  ?     4039           
  Partials                ?     2134

@colm-mchugh Colm (colm-mchugh) mentioned this pull request Dec 2, 2024
Merged
@naisila

Naisila Puka (naisila) commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

I don't know if it's a glitch on my side, but I only see an irrelevant commit in this PR (something about fixing test failure in multi_name_lengths)

@colm-mchugh

Colm (colm-mchugh) commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

I don't know if it's a glitch on my side, but I only see an irrelevant commit in this PR (something about fixing test failure in multi_name_lengths)

This PR is meant to contain the same commits as releas-13.0, minus the commit for #7253. But its created a different commit for the tip, it should be e9110de. I need to fix that..

@colm-mchugh
Revert "PG17 regress sanity: fix error unrecognized alter database op…
491547d 
…tion tablespace seen in database vanilla test (#7764)"

PG17 compatibility: revert commit d5f067a.

We need to have default `enable_metadata_sync` value for vanilla regress tests.
Need to determine another way to manage the vanilla database regress
test failure.
@colm-mchugh

Colm (colm-mchugh) commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

I don't know if it's a glitch on my side, but I only see an irrelevant commit in this PR (something about fixing test failure in multi_name_lengths)

Updated the PR with an explicit revert commit.

naisila
Naisila Puka (naisila) approved these changes Dec 2, 2024
View reviewed changes

@naisila Naisila Puka (naisila) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colm-mchugh
Colm (colm-mchugh) merged commit 5f479d5 into release-13.0 Dec 3, 2024
@colm-mchugh
Colm (colm-mchugh) deleted the cmchugh/pg17-revert-7253 branch December 3, 2024 08:44
Naisila Puka (naisila) pushed a commit that referenced this pull request Mar 11, 2025
@colm-mchugh @naisila
PG17 compatibility: revert #7764 (#7775)
7f4509e 
Revert PG17 compatibility fix #7764
Naisila Puka (naisila) pushed a commit that referenced this pull request Mar 12, 2025
@colm-mchugh @naisila
PG17 compatibility: revert #7764 (#7775)
b6f183b 
Revert PG17 compatibility fix #7764
Naisila Puka (naisila) pushed a commit that referenced this pull request Mar 12, 2025
@colm-mchugh @naisila
PG17 compatibility: revert #7764 (#7775)
6254ad8 
Revert PG17 compatibility fix #7764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@naisila Naisila Puka (naisila) naisila approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colm-mchugh @naisila