Skip to content

Conversation

@reidmorrison
Copy link

This PR reproduces an issue where MultiTenant.with(account) has different behavior from MultiTenant.with(account.id) when calling delete_all or update_all.

Is it expected for the behavior to differ, or should we go ahead and remove the following 2 lines in order to make the behavior consistent for delete_all and update_all?
https://github.com/citusdata/activerecord-multi-tenant/blob/master/lib/activerecord-multi-tenant/relation_extension.rb#L8
And
https://github.com/citusdata/activerecord-multi-tenant/blob/master/lib/activerecord-multi-tenant/relation_extension.rb#L20

@reidmorrison
Copy link
Author

@microsoft-github-policy-service agree company="Salesloft"

@reidmorrison
Copy link
Author

@reidmorrison please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Salesloft"

@reidmorrison
Copy link
Author

The tests are now passing locally after these changes made in the PR were merged into master: 20d09a8
Please consider merging this pull request which now only adds tests, since they now include test coverage for the scenario that was fixed.

@reidmorrison reidmorrison changed the title delete_all has different behavior when supplying an id instead of an object Increase test coverage for delete_all when supplying an id instead of an object Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant