Skip to content

API-3333 Support Default Time #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Conversation

boygao1992
Copy link
Member

@boygao1992 boygao1992 commented Aug 16, 2023

What does this pull request do?

Added defaultTime to DateTimePicker.Input for auto populating Time with a default value when a Date is selected.

Also made some small improvements in DateTimePicker and fixed formatting of UIGuide.

How should this be manually tested?

  • make and go to /dist/index.html#date-pickers
  • scroll to Standard - Without Interval at the bottom of the page
  • select a Date
    • the Time should be automatically set to 1:30 AM
  • refresh the page to reset state. Select a Time and then Date
    • the selected Time should not be overridden by the default value (1:30 AM)

Before user selecting both Date and Time, we don't want to raise
selection and trigger validation.
for auto populating Time with a default value when Date is selected
@boygao1992 boygao1992 requested review from a team and allgooda and removed request for a team August 16, 2023 00:53
Copy link
Member

@davezuch davezuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@allgooda allgooda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@boygao1992
Copy link
Member Author

Thanks for the review!

@boygao1992 boygao1992 merged commit f643e66 into main Aug 16, 2023
@boygao1992 boygao1992 deleted the wenbo/API-3333/support-default-time branch August 16, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants