Skip to content

FBCM-4913 Expand MultiInput inner input field to fill the whole container #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

arthurxavierx
Copy link
Contributor

What does this pull request do?

Currently the MultiInput component has an inner auto-sized input field whose initial width corresponds to that of the placeholder text. This makes is difficult for users to interact with the component, because in order to start typing in, they must necessarily click on the placeholder text, as clicking on anywhere else in the container wouldn't hit the
inner input field. This pull request fixes that behavior.

How should this be manually tested?

  • Clicking on any part of the MultiInput container should focus on the input field.
  • The inner input field should resize according to the text when adding a new element at the end.
  • The inner input field should resize according to the text when editing an existing element in the middle.

Other Notes:

This is the same PR as #239. We chose to close that and open a new one because CI got stuck.

@arthurxavierx arthurxavierx requested a review from boygao1992 June 27, 2022 17:54
@arthurxavierx arthurxavierx self-assigned this Jun 27, 2022
@boygao1992
Copy link
Member

boygao1992 commented Jun 27, 2022

Hmm still not delivered. (3rd one is the PR, 1st one is my retry of the 3rd one)

@davezuch Do you know what's going on with the CI?

@davezuch
Copy link
Member

davezuch commented Jun 27, 2022

@davezuch Do you know what's going on with the CI?

Not sure. I found this support page by CircleCI:

If you are seeing the response 400 in spite of having the read/write/admin access to the repository, please try to completely re-authenticating, i.e. sign out of Github in the browser, sign out of CircleCI, then log back into CircleCI via Github.

You can also follow the below steps to cause CircleCI to generate a new webhook:

  1. Unfollow the project from the CircleCI ‘Project settings’ page - click the ‘Unfollow’ button
  2. Remove the webhook for the affected repo on GitHub (Settings > Webhooks and services)
  3. Re-add the project by following the project again on the CircleCI ‘Project settings’ page

@arthurxavierx maybe try authenticating with CircleCI.

@arthurxavierx
Copy link
Contributor Author

Weird, I just logged in to CircleCI but can't see my branch in there. Will try force-pushing to see if it shows up.

Currently the MultiInput component has an inner auto-sized input field
whose initial width corresponds to that of the placeholder text. This
makes is difficult for users to interact with the component, because in
order to start typing in, they must necessarily click on the placeholder
text, as clicking on anywhere else in the container wouldn't hit the
inner input field.
@arthurxavierx arthurxavierx force-pushed the arthur/multi-input-full-width branch from 994b301 to 54c4bda Compare June 27, 2022 18:59
@arthurxavierx
Copy link
Contributor Author

Yep, that seems to have done it. Thanks for the help! :)

@arthurxavierx arthurxavierx enabled auto-merge June 27, 2022 19:00
@arthurxavierx arthurxavierx merged commit f2432d9 into main Jun 27, 2022
@arthurxavierx arthurxavierx deleted the arthur/multi-input-full-width branch June 27, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants