Fix Ocelot.Data.Currency functions not working with negative Cents values
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we add test cases for negative `Cents` value and a property test for the interaction between `parseCentsFromDollarStr` and `formatCentsToStrDollars`. These tests are failing at the moment and we fix the code and get them to pass in the next commit.
Previously these functions did not work properly with negative `Cents` values.
|
@arthurxavierx Don't forget to bump version like this and make a release. |
|
@boygao1992 Do you know why the CircleCI build hasn't finished yet? |
|
Hmm I don't see this PR on the job list. |
|
Weird, I just opened a new branch and the CI is triggered. Maybe try pushing to a different branch? |
|
@arthurxavierx I just did that for you creating a new branch |
|
@boygao1992 Oh it seems like the original branch got built and already merged for some reason 😶 Thank you! |
|
Nvm, since both branches are on the same commit. That CI passing triggered the auto merge. |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
The
Ocelot.Data.Currency.formatCentsToStrDollarsandOcelot.Data.Currency.parseCentsFromDollarStrdid not work with negativeCentsvalues. We fix that by changing their definitions and adding test cases to cover the intended behavior.Where should the reviewer start?
Commit-by-commit.
How should this be manually tested?
There's no need for manual testing; the automated tests should be enough.