Skip to content

AS-2079 Add Ad Set and Campaign Icons #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2022
Merged

AS-2079 Add Ad Set and Campaign Icons #214

merged 8 commits into from
Jan 25, 2022

Conversation

boygao1992
Copy link
Member

@boygao1992 boygao1992 commented Jan 25, 2022 •
edited by davezuch
Loading

What does this pull request do?

Add two new svg icons to font-family ocelot-icon-v2. Also add two-digit ordinal to svg file names to keep them in order for reducing the amount of changes in icon.css file.

How should this be manually tested?

  • delete .css files under dist folder and then make build
  • go to dist/index.html#icons and scroll to the bottom
    • all social icons should show up like normal
    • the Ad Set icon and Campaign icon should look like this

@boygao1992 boygao1992 requested a review from davezuch January 25, 2022 01:06
davezuch
davezuch approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@davezuch davezuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@boygao1992
Copy link
Member Author

Thanks for the review!

@boygao1992 boygao1992 merged commit 2e2924d into main Jan 25, 2022
@boygao1992 boygao1992 deleted the AS-2079/add-ad-set-campaign-icons branch January 25, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davezuch davezuch davezuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boygao1992 @davezuch