API-1813 Allow Selecting Multiple in renderToolbarSearchDropdown #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a multi-select version of `renderToolbarSearchDropdown` which returns `Array` instead of `Maybe`. `renderToolbarSearchDropdown` depends on `renderSearchDropdown` so we start from here.
We used to take a default label String and a text render function for a single selection with `Maybe` in `renderToolbarSearchDropdown`. Now we want to support multiple selections with `Array`, the presentation of text as a summary of selections could vary depending on different situations, e.g. a comma separated list of all selections, or the count of selections, etc. so we let users to provide the render function instead of making a decision for them.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Before
Ocelot.Typeahead.renderToolbarSearchDropdownwas fixed toMaybefor single selection but we need it to support multiple selection withArrayso we loosenrenderSearchDropdownandrenderToolbarSearchDropdownto supportFoldableinstead of justMaybe.How should this be manually tested?
make/dist/index.html#typeaheadsand scroll down to the bottom, the last one should be a multi-select toolbar search dropdownAll Locations)