Skip to content

Conversation

cprussin
Copy link
Collaborator

@cprussin cprussin commented May 4, 2022

No description provided.

@@ -8,7 +8,7 @@ on:
- "v[0-9]*.[0-9]*.x"

jobs:
Setup Environment:
Setup_Environment:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are step names not allowed to have spaces?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately seems like they are not: https://github.com/citizennet/purescript-httpure/actions/runs/2272722569

The workflow is not valid. .github/workflows/check.yaml (Line: 11, Col: 3): The identifier 'Setup Environment' is invalid. IDs may only contain alphanumeric characters, '', and '-'. IDs must start with a letter or '' and and must be less than 100 characters. .github/workflows/check.yaml (Line: 62, Col: 3): The identifier 'Validate Purescript Format' is invalid. IDs may only contain alphanumeric characters, '', and '-'. IDs must start with a letter or '' and and must be less than 100 characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha, thanks for the explanation!

Copy link
Member

@davezuch davezuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't know Nix well enough yet to confidently review these changes, but they seem sensible to me.

@cprussin
Copy link
Collaborator Author

cprussin commented May 5, 2022

@davezuch no worries, I'm happy to keep lending a hand on the nix side of things especially, given my passion for nix and personal desire to not see nix stripped out of here :)

@davezuch
Copy link
Member

davezuch commented May 5, 2022

@cprussin sounds good! It seems we're wanting to start leaning more on Nix on our team anyway, so I'm glad this repo relies on it.

@cprussin
Copy link
Collaborator Author

cprussin commented May 5, 2022

@davezuch looks like the branch protection rules will need to be updated to merge this, given I changed the job names and so the required jobs no longer exist.

Can you either update them or grant me admin so I can update them myself?

@davezuch davezuch merged commit 2286472 into main May 5, 2022
@davezuch
Copy link
Member

davezuch commented May 5, 2022

@cprussin done and done!

@davezuch davezuch deleted the optimize-ci branch May 5, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants