-
Notifications
You must be signed in to change notification settings - Fork 16
Use niv out of nixpkgs #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -8,7 +8,7 @@ on: | |||
- "v[0-9]*.[0-9]*.x" | |||
|
|||
jobs: | |||
Setup Environment: | |||
Setup_Environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are step names not allowed to have spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately seems like they are not: https://github.com/citizennet/purescript-httpure/actions/runs/2272722569
The workflow is not valid. .github/workflows/check.yaml (Line: 11, Col: 3): The identifier 'Setup Environment' is invalid. IDs may only contain alphanumeric characters, '', and '-'. IDs must start with a letter or '' and and must be less than 100 characters. .github/workflows/check.yaml (Line: 62, Col: 3): The identifier 'Validate Purescript Format' is invalid. IDs may only contain alphanumeric characters, '', and '-'. IDs must start with a letter or '' and and must be less than 100 characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha, thanks for the explanation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't know Nix well enough yet to confidently review these changes, but they seem sensible to me.
@davezuch no worries, I'm happy to keep lending a hand on the nix side of things especially, given my passion for nix and personal desire to not see nix stripped out of here :) |
@cprussin sounds good! It seems we're wanting to start leaning more on Nix on our team anyway, so I'm glad this repo relies on it. |
@davezuch looks like the branch protection rules will need to be updated to merge this, given I changed the job names and so the required jobs no longer exist. Can you either update them or grant me admin so I can update them myself? |
@cprussin done and done! |
No description provided.