Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title-short for APA styles #623

Merged
merged 3 commits into from
Jul 5, 2013
Merged

Conversation

pietsch
Copy link
Contributor

@pietsch pietsch commented Jul 5, 2013

Everybody calls APA styles “APA styles”, so this should be searchable. Without this patch, you would have to search for “American Psychological Association”.

@rmzelle
Copy link
Member

rmzelle commented Jul 5, 2013

I agree that this should be added. Although at least for the Zotero Style Repository, searches also match the file name, so "apa" should already find these styles.

Would you mind removing yourself as a contributor, though? There is a slight cost for adding contributors (styles get a little bit more bulky), and this is a rather trivial change (for this reason I didn't include my own name for the thousands of styles of which I improved the metadata). The pull request is still appreciated!

@pietsch
Copy link
Contributor Author

pietsch commented Jul 5, 2013

jQuery-enhanced select boxes by default do not match against the value attribute (Chosen.js cannot do it, Select2.js can do it with a custom matcher). This is why I think title-short is generally needed even when it repeats parts of the filename.

I have removed myself from the contributor lists -- I was not sure about your policy.

@rmzelle
Copy link
Member

rmzelle commented Jul 5, 2013

Thanks. And yes, the style metadata should be as complete as possible. Just curious, what software product were you thinking of with regard to your comment about jQuery?

@pietsch
Copy link
Contributor Author

pietsch commented Jul 5, 2013

We have connected a citeproc-node server to Bielefeld University's library catalogue as mentioned here: https://twitter.com/ChPietsch/status/351686085102940160
The web interface currently uses Chosen2.js, but we might switch to Select2.js: http://katalogplus.ub.uni-bielefeld.de/title/2314439 (try “andere Stile”!)

@rmzelle
Copy link
Member

rmzelle commented Jul 5, 2013

Ah, right, I even retweeted you. Drew a blank.

I think you are the first university library to use CSL!

rmzelle added a commit that referenced this pull request Jul 5, 2013
title-short for APA styles
@rmzelle rmzelle merged commit b397624 into citation-style-language:master Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants