Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create journal-of-bone-and-mineral-research.csl #610

Merged
merged 3 commits into from
Jun 22, 2013

Conversation

emcnerny
Copy link
Contributor

Modified Vancouver style to match JBMR's requirements of parenthetical superscript in-line citations and no et al. in bibliography author lists.

Modified Vancouver style to match JBMR's requirements of parenthetical superscript in-line citations and no et al. in bibliography author lists.
@@ -0,0 +1,262 @@
<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="sort-only" page-range-format="minimal">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is an English journal, could you add default-locale="en-US" two this line (i.e. line 2)

@adam3smith
Copy link
Member

see the two nits above, otherwise looks great, thanks!
You can update your pull request by editing the file here:
https://github.com/emcnerny/styles/blob/patch-1/journal-of-bone-and-mineral-research.csl
let us know when you're done, we don't get notified for updated pull requests

@emcnerny
Copy link
Contributor Author

Changes made! :)

On Sat, Jun 22, 2013 at 5:23 PM, Sebastian Karcher <notifications@github.com

wrote:

see the two nits above, otherwise looks great, thanks!
You can update your pull request by editing the file here:

https://github.com/emcnerny/styles/blob/patch-1/journal-of-bone-and-mineral-research.csl
let us know when you're done, we don't get notified for updated pull
requests


Reply to this email directly or view it on GitHubhttps://github.com//pull/610#issuecomment-19864945
.

@rmzelle
Copy link
Member

rmzelle commented Jun 22, 2013

Two more things:

The line <link href="http://www.ncbi.nlm.nih.gov/bookshelf/br.fcgi?book=citmed" rel="documentation"/> can be deleted. Also http://www.ncbi.nlm.nih.gov/nlmcatalog/8610640 shows that the ISSN is 0884-0431 (<issn/>) and the eISSN is 1523-4681 (<eissn/>).

@emcnerny
Copy link
Contributor Author

rmzelle's changes made.

@rmzelle
Copy link
Member

rmzelle commented Jun 22, 2013

Perfect, thanks!

rmzelle added a commit that referenced this pull request Jun 22, 2013
Create journal-of-bone-and-mineral-research.csl
@rmzelle rmzelle merged commit 48d8af8 into citation-style-language:master Jun 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants