Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create trinity-college-dublin-zoology-botany-environmental-sciences-h… #5893

Merged
merged 5 commits into from
Feb 7, 2022

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Feb 5, 2022

…arvard.csl

Style I've developed for a requestor via emails.
Style has been reviewed and signed off
Guidelines: FBU44000_Thesis Writing Guidelines 2021-22 References.docx
.

…arvard.csl

Style I've developed for a requestor via emails.
Requestor is Asst. Professor at TCD and style has been reviewed and signed off.
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

😟 There are some issues with your submission.

2 tests failed

trinity-college-dublin-zoology-botany-environmental-sciences-harvard: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

trinity-college-dublin-zoology-botany-environmental-sciences-harvard: may not have any unused macros

expected: []
     got: ["anon"]

(compared using ==)

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

😟 There are some issues with your submission.

2 tests failed

trinity-college-dublin-zoology-botany-environmental-sciences-harvard: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

trinity-college-dublin-zoology-botany-environmental-sciences-harvard: may not have any unused macros

expected: []
     got: ["anon"]

(compared using ==)

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

😟 There are some issues with your submission.

1 test failed

trinity-college-dublin-zoology-botany-environmental-sciences-harvard: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

trinity-college-dublin-zoology-botany-environmental-sciences-harvard.csl (new)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example. (2012). Citation Style Editor http://editor.citationstyles.org/searchByExample/. Visited: 15th December 2012.
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6: 28.
Hancké, B., Rhodes, M., Thatcher, M. (eds). (2007). Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, Oxford and New York.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall, P.A. & Soskice, D. (eds) Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. 184–213.

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

trinity-college-dublin-zoology-botany-environmental-sciences-harvard.csl (new)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example. (2012). Citation Style Editor http://editor.citationstyles.org/searchByExample/. Visited: 15th December 2012.
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6: 28.
Hancké, B., Rhodes, M., Thatcher, M. (eds). (2007). Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, Oxford and New York.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall, P.A. & Soskice, D. (eds) Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York, pp. 184–213.

@adam3smith
Copy link
Member

did you get a sense if these are going to be fairly permanent? I don't mind adding a style for a single department (we have a bunch) but wouldn't want this if this is for a specific cohort (the guidelines say 2021-22 in the filename, but that doesn't have to mean they're just for this year)

@POBrien333
Copy link
Contributor Author

No, this will be permanent. They've only really started with this.

@adam3smith adam3smith merged commit 1a2ea12 into citation-style-language:master Feb 7, 2022
@adam3smith
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants