Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add medium to IEEE #5846

Merged
merged 3 commits into from
Jan 16, 2022
Merged

add medium to IEEE #5846

merged 3 commits into from
Jan 16, 2022

Conversation

adam3smith
Copy link
Member

See
https://forums.zotero.org/discussion/93801/how-to-cite-lectures-in-the-ieee-citation-style-using-zotero#latest
(not doing type/genre because it interferes with online presentations)

@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/ (accessed Dec. 15, 2012).
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds. New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

ieee.csl Outdated
</if>
<else-if type="speech" variable="genre" match="all">
<text variable="medium" text-case="capitalize-first"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will never render anything because if an item has medium it will hit the previous condition

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, that was a typo. I meant to use genre, but ended up removing this again because "type" is used for things that definitely shouldn't be in square brackets for IEEE.

Doesn't work with e.g. conference paper/presentation etc. which would 
all be genre
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/ (accessed Dec. 15, 2012).
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds. New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

@adam3smith adam3smith merged commit 1455165 into master Jan 16, 2022
@adam3smith adam3smith deleted the ieee-medium branch January 16, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants