-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add medium to IEEE #5846
add medium to IEEE #5846
Conversation
See https://forums.zotero.org/discussion/93801/how-to-cite-lectures-in-the-ieee-citation-style-using-zotero#latest (not doing type/genre because it interferes with online presentations)
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: ieee.csl (modified style; unchanged output for sample items)[1], [2] |
ieee.csl
Outdated
</if> | ||
<else-if type="speech" variable="genre" match="all"> | ||
<text variable="medium" text-case="capitalize-first"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never render anything because if an item has medium it will hit the previous condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, that was a typo. I meant to use genre, but ended up removing this again because "type" is used for things that definitely shouldn't be in square brackets for IEEE.
Doesn't work with e.g. conference paper/presentation etc. which would all be genre
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: ieee.csl (modified style; unchanged output for sample items)[1], [2] |
See
https://forums.zotero.org/discussion/93801/how-to-cite-lectures-in-the-ieee-citation-style-using-zotero#latest
(not doing type/genre because it interferes with online presentations)