Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create international-journal-of-lexicography.csl #544

Merged
merged 3 commits into from
May 10, 2013

Conversation

rlewijl
Copy link
Contributor

@rlewijl rlewijl commented May 10, 2013

No description provided.

@rmzelle
Copy link
Member

rmzelle commented May 10, 2013

Could you make a few changes to the style by using the Edit button at https://github.com/rlewijl/styles/blob/patch-1/international-journal-of-lexicography.csl so we can accept this style? In particular:

  • we don't include style author names in the style title
  • the style should carry the "default-locale" attribute on <style/>; apparently the journal uses British English, so the attribute value should be "en-GB"
  • the style ID should be <id>http://www.zotero.org/styles/international-journal-of-lexicography</id>
  • the style needs a "self" link, as in <link href="http://www.zotero.org/styles/international-journal-of-lexicography" rel="self"/>
  • the online ISSN (1477-4577) should be marked up with <eissn/> instead of <issn/>
  • the style needs a "template" link, as in <link href="http://www.zotero.org/styles/unified-style-linguistics" rel="template"/>
  • the style needs a "documentation" link to the journal's website, as in <link href="http://www.oxfordjournals.org/our_journals/lexico/for_authors/index.html" rel="documentation"/>

Would you mind taking care of all this?

@rlewijl
Copy link
Contributor Author

rlewijl commented May 10, 2013

I appreciate the detailed and clear instructions, as am a complete beginner at this. I just undertook this as I am the editor of this journal.
I believe I have now effected all the suggested modifications.
I'm just not sure about the template link to unified-style-linguistics, as I have changed a lot, just happened to start with this one.

Could anyone advise how to change the appearance of the year, so that no dot appears in the citation? I added it as a suffix to the macro to have the bold attribute extend to the dot when following author in the bibliography, but now it's been pointed out to me that this way the dot appears also in the citation, which is undesirable. Perhaps a way to achieve this is to nest the year alone in the citation (as a named element, not date macro? - not sure if I got my terminology right here).
thx!

</group>
</macro>
<macro name="date">
<date variable="issued" suffix=".">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the suffix="." from here and add it here https://github.com/citation-style-language/styles/pull/544/files#L0R359 , i.e. where the macro is inserted in the bibliography

@adam3smith
Copy link
Member

I'd recommend putting the unified stylesheet in as a template even if you changed a fair amount. That makes it easier for us, among other things, to identify the propagation of certain quirks in coding styles.

Together with my two comments in the code that should be all before we can merge this.

@rlewijl
Copy link
Contributor Author

rlewijl commented May 10, 2013

Many thanks, adam3smith for the two keen observations.
Hope now I did it right.

adam3smith added a commit that referenced this pull request May 10, 2013
Create international-journal-of-lexicography.csl
@adam3smith adam3smith merged commit 6ca24ee into citation-style-language:master May 10, 2013
@adam3smith
Copy link
Member

excellent - thanks. We also appreciate you taking this into your own hands as a journal editor, we wish that would happen much more.

@rlewijl rlewijl deleted the patch-1 branch May 10, 2013 18:21
@rmzelle
Copy link
Member

rmzelle commented May 10, 2013

@rlewijl, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants