Update Juristische Zitierweise (Stüber) #3618

zuphilip · 2018-07-21T09:38:13Z

chapter: fix mismatched use of title instead of container-title
chapter: add first page besides pages from locator, similar to journal article,
e.g. Knemeyer, in: von Mutius, FG für von Unruh, S. 209 (209).
use non-breakable space between locator and label
encyclopedia-aricles: fix problem when title is missing
prefer short-title in footnote citations
wegpage: add date in bibliography with prefix "Stand: "

- chapter: fix mismatched use of title instead of container-title - chapter: add first page besides pages from locator, similar to journal article, e.g. Knemeyer, in: von Mutius, FG für von Unruh, S. 209 (209). - use non-breakable space between locator and label - encyclopedia-aricles: fix problem when title is missing - prefer short-title in footnote citations - wegpage: add date in bibliography with prefix "Stand: "

csl-bot · 2018-07-21T09:38:20Z

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

zuphilip · 2018-07-21T09:40:40Z

juristische-zitierweise.csl

@@ -60,7 +60,7 @@
        <names variable="editor">
          <name form="short" delimiter="/" initialize-with=""/>
        </names>
-        <text variable="title"/>
+        <text variable="container-title" form="short"/>


I added manually a container-title-short in one example of the csl-editor but this did not show up here. Is that forbidden for a chapter?

No, CSL 1.0.1 puts no restrictions on which fields can be used with which item types. Might be some kind of bug in the editor. (if it's not too much work, it might help if you could give the exact steps to reproduce this problem)

Okay, I created an item of type chapter in Zotero and export it to CSL JSON, added there the field container-title-short with a value and then import that (without the outermost parenthesis for a set) into the CSL editor, where I don't see any effect of the short container title.

I used this CSL-JSON data

{ "id": "http://zotero.org/users/96641/items/TFNFUVLI", "type": "chapter", "title": "Endnotes", "container-title": "The World is Open", "container-title-short": "TWO", "publisher": "Wiley-Blackwell", "page": "427-467", "source": "Wiley Online Library", "URL": "https://onlinelibrary.wiley.com/doi/abs/10.1002/9781118269381.notes", "ISBN": "978-1-118-26938-1", "note": "DOI: 10.1002/9781118269381.notes", "language": "en", "issued": { "date-parts": [ [ "2012" ] ] }, "accessed": { "date-parts": [ [ "2018", 7, 2 ] ] } }

Any idea?

This seems to work fine for me. I loaded this JSON into the visual editor, and edited the style to use

<text variable="container-title-short"/>

which prints "TWO" for the bibliography:

Okay, and what happens if you take instead

<text variable="container-title" form="short"/>

?

This seems like a similar situation to what we had with "shortTitle" and "title-short". I can raise the issue with Frank.

That would be great. Thank you!

Anything we should do in this PR or can it be merged now?

Anything we should do in this PR or can it be merged now?

Well, <text variable="container-title" form="short"/> and <text variable="container-title-short"/> are both correct CSL in this case. And as Zotero currently doesn't offer a variable for chapters (https://aurimasv.github.io/z2csl/typeMap.xml#map-bookSection), it doesn't really matter which one we pick here.

Do both variants use container-title if the short form is not present?

Do you suggest to switch the form here? Maybe I am missing something else here...?

Do both variants use container-title if the short form is not present?

I think only the form="short" call has fallback to the "long" form if unavailable. See http://docs.citationstyles.org/en/1.0.1/specification.html#text. Pretty sure the CSL specification is silent on fallback for "container-title-short".

Okay. How do you want to finish this PR then? (I would like to complete this soon as I have promised to some PhD candidates here...)

csl-bot · 2018-07-21T09:41:04Z

😃 Your submission passed all our automated tests.

rmzelle · 2018-07-26T12:26:48Z

juristische-zitierweise.csl

@@ -40,7 +40,7 @@
    </names>
  </macro>
  <macro name="locator-with-label">
-    <group delimiter=" ">
+    <group delimiter="&amp;#160;">


Did you add these non-breaking spaces by hand? And did you actually test the style? This doesn't look correct.

& is the ampersand, and is followed by plain text "#160;". To get a non-breaking space, only use  .

@zuphilip, bump.

I added them by hand in the CSL editor and they still look fine within the editor:

It might simply be that exporting the style from there is then escaping it wrongly.

Okay, I checked and it is also in the Code editor wrongly escaped. I will fix these issues w/o the editor.

Maybe copy and pasting the non-breaking space character into the delimiter field works. But yeah, it looks like the code escapes the ampersand sign.

rmzelle · 2018-07-26T12:27:04Z

juristische-zitierweise.csl

@@ -111,14 +111,22 @@
          <group delimiter=", ">
            <text macro="author-note"/>
            <text macro="inbook"/>
-            <text macro="locator-with-label"/>
+            <group delimiter=" ">
+              <group delimiter="&amp;#160;">


Same issue here.

rmzelle · 2018-07-26T12:27:59Z

juristische-zitierweise.csl

@@ -247,6 +255,7 @@
          <group delimiter=", ">
            <text macro="author"/>
            <text variable="title"/>
+            <date form="text" variable="issued" prefix="Stand: "/>


Just curious, what does the "Stand" label mean?

Stand would roughly translates to "as it stands as of [date]" so it's somewhat similar to accessed on, but not quite (which is why I assume zuphilip is using it with the issued date)

"Stand" is IMO a data which represents the version/edition of that work, and yes @adam3smith is right that I therefore choose here the variable issued. However, websites are only used rarely in law publications.

csl-bot · 2018-08-07T14:06:47Z

😃 Your submission passed all our automated tests.

zuphilip · 2018-08-07T14:26:39Z

Okay, I updated the style according to your remarks @rmzelle . That should be fine now.

csl-bot · 2018-08-11T04:59:06Z

😃 Your submission passed all our automated tests.

rmzelle · 2018-08-14T03:43:32Z

Thanks!

zuphilip · 2018-08-14T05:23:31Z

Thank you!

zuphilip commented Jul 21, 2018

View reviewed changes

rmzelle reviewed Jul 26, 2018

View reviewed changes

adam3smith added the waiting The ticket/pull request is awaiting input from the contributor/depositor label Aug 4, 2018

Unescape ampersance for nonbreaking space

949409c

adam3smith removed the waiting The ticket/pull request is awaiting input from the contributor/depositor label Aug 7, 2018

Update juristische-zitierweise.csl

36f886c

rmzelle merged commit 4ee024a into citation-style-language:master Aug 14, 2018

rmzelle mentioned this pull request Aug 14, 2018

Treat "container-title-short" the same as "journalAbbreviation" Juris-M/citeproc-js#84

Closed

zuphilip deleted the stueber-2018 branch August 14, 2018 05:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Juristische Zitierweise (Stüber) #3618

Update Juristische Zitierweise (Stüber) #3618

zuphilip commented Jul 21, 2018

csl-bot commented Jul 21, 2018

zuphilip Jul 21, 2018 •

edited

Loading

rmzelle Jul 26, 2018

zuphilip Aug 7, 2018

rmzelle Aug 11, 2018

zuphilip Aug 11, 2018

zuphilip Aug 11, 2018

rmzelle Aug 11, 2018

zuphilip Aug 11, 2018

rmzelle Aug 13, 2018

zuphilip Aug 13, 2018

csl-bot commented Jul 21, 2018

rmzelle Jul 26, 2018

rmzelle Aug 5, 2018

zuphilip Aug 7, 2018

zuphilip Aug 7, 2018

rmzelle Aug 11, 2018

rmzelle Jul 26, 2018

rmzelle Jul 26, 2018

adam3smith Jul 26, 2018

zuphilip Aug 7, 2018

csl-bot commented Aug 7, 2018

zuphilip commented Aug 7, 2018

csl-bot commented Aug 11, 2018

rmzelle commented Aug 14, 2018

zuphilip commented Aug 14, 2018

Update Juristische Zitierweise (Stüber) #3618

Update Juristische Zitierweise (Stüber) #3618

Conversation

zuphilip commented Jul 21, 2018

csl-bot commented Jul 21, 2018

zuphilip Jul 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csl-bot commented Jul 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csl-bot commented Aug 7, 2018

zuphilip commented Aug 7, 2018

csl-bot commented Aug 11, 2018

rmzelle commented Aug 14, 2018

zuphilip commented Aug 14, 2018

zuphilip Jul 21, 2018 •

edited

Loading