Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update international-review-of-the-red-cross.csl #3242

Merged
merged 4 commits into from
Jan 5, 2018

Conversation

scarnecchia
Copy link
Contributor

Fixed: fixed a persist issue with delimiters which caused double commas between fields.
Fixed: lack of space between series name and date in publication type: reports
Added: Proper formatting for newspaper articles
Added: proper formatting for internet sources

Fixed: fixed a persist issue with delimiters which caused double commas between fields.
Fixed: lack of space between series name and date in publication type: reports
Added: Proper formatting for newspaper articles
Added: proper formatting for internet sources
@csl-bot
Copy link

csl-bot commented Jan 4, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Jan 4, 2018

😟 There are some issues with your submission. Please check the test report for details.

Whoops! Left a suffix someplace it shouldn't be (line 172)
@csl-bot
Copy link

csl-bot commented Jan 4, 2018

😃 Your submission passed all our automated tests.

Added a missing comma between date and page in journals.
@csl-bot
Copy link

csl-bot commented Jan 4, 2018

😃 Your submission passed all our automated tests.

@csl-bot
Copy link

csl-bot commented Jan 5, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 52c5c76 into citation-style-language:master Jan 5, 2018
@rmzelle
Copy link
Member

rmzelle commented Jan 5, 2018

Thanks!

For future contributions, could you please always start out from the latest version in the style repository? I made some corrections in your previous pull request (d5f720b) and I had to reapply those here.

@scarnecchia
Copy link
Contributor Author

Absolutely!

@scarnecchia scarnecchia deleted the patch-4 branch January 5, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants