Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename dependent/american-journal-of-hypertension.csl to a… #2750

Merged
merged 2 commits into from
Jun 20, 2017

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Jun 19, 2017

via #2705

@csl-bot
Copy link

csl-bot commented Jun 19, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Jun 19, 2017

😃 Your submission passed all our automated tests.

</group>
<text variable="page" prefix=":"/>
</group>
<text variable="DOI" prefix=" &lt;" suffix="&gt;"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damnation333, where did you find this? I e.g. found this open access article, which doesn't print DOIs at all (https://academic.oup.com/ajh/article/30/7/683/3739803/An-Assessment-of-the-Accuracy-of-Home-Blood), and the instructions also don't seem to mention them (https://academic.oup.com/ajh/pages/general_instructions#FormatofManuscripts).

Unless they're very clear about this, I'd just use the URL format here.

@POBrien333
Copy link
Contributor Author

POBrien333 commented Jun 20, 2017

@rmzelle
I had seen it here: Reference 4 https://academic.oup.com/ajh/article/30/6/587/3064943/Association-of-Blood-Pressure-Trajectory-With
Probably just the exemption to the rule. haha

@rmzelle
Copy link
Member

rmzelle commented Jun 20, 2017

@damnation333, they still add the URL prefix there: <http://dx.doi.org/10.1001/jama.2016.7050>, in addition to the angle brackets. So I would go with <https://doi.org/...> here (especially since they already use DOI: https://doi.org/10.1093/ajh/hpx028 elsewhere on the page.

@csl-bot
Copy link

csl-bot commented Jun 20, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 59b538d into citation-style-language:master Jun 20, 2017
@rmzelle
Copy link
Member

rmzelle commented Jun 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants