Update technische-universitat-munchen-controlling.csl #2664
Conversation
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
|
This search shows also that these are all occurences: https://github.com/citation-style-language/styles/search?utf8=%E2%9C%93&q=hwr&type= |
|
😃 Your submission passed all our automated tests. |
1 similar comment
|
😃 Your submission passed all our automated tests. |
|
thanks! |
| @@ -7,7 +7,7 @@ | |||
| <id>http://www.zotero.org/styles/technische-universitat-munchen-controlling</id> | |||
| <link href="http://www.zotero.org/styles/technische-universitat-munchen-controlling" rel="self"/> | |||
| <link href="http://www.zotero.org/styles/universitat-freiburg-geschichte" rel="template"/> | |||
| <link href="http://www.zotero.org/styles/hwr-berlin" rel="template"/> | |||
| <link href="http://www.zotero.org/styles/hochschule-fur-wirtschaft-und-recht-berlin" rel="template"/> | |||
There was a problem hiding this comment.
@adam3smith, @zuphilip, only now seeing this, but I'm confused.
This template style was renamed in 2013 (see d675473#diff-2657503fcaf93aaf9836fa01c692099eR22 and d675473#diff-2657503fcaf93aaf9836fa01c692099eR22). Shouldn't our automatic tests have caught this way back? I'm pretty sure we're testing whether the template style exists in the current repository.
I'll take a look.
There was a problem hiding this comment.
We definitely do, yes -- without actually having looked at the code, I'm guessing the test might just look if the first template exists. This style has two.
There was a problem hiding this comment.
Right, that's it. Just discovered that independently :P.
(the code for checking the template link is at
Line 26 in a6646ba
There was a problem hiding this comment.
Okay, (low-priority) issue created: #2802
The hwr-berlin style was renamed, cf.
styles/renamed-styles.json
Line 289 in e09bfc0