Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update american-sociological-association.csl #2131

Merged
merged 1 commit into from
Jul 11, 2016

Conversation

agruber
Copy link
Contributor

@agruber agruber commented Jun 28, 2016

Apply title case transformation to container-title in the else conditional that is called for article-journal. It is done so already for article-newspaper and article-magazine.

Apply title case transformation to container-title in the else conditional that is called for article-journal. It is done so already for article-newspaper and article-magazine.
@csl-bot
Copy link

csl-bot commented Jun 28, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Jun 28, 2016

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

I'm a bit worried about doing this for journals where we may get unintended results for non-English journal titles. At the same time, how often does this come up?

@agruber
Copy link
Contributor Author

agruber commented Jun 28, 2016

It is already in place for article-newspaper and article-magazine, so also this will then give an incorrect result. There are two routes to go from here: either delete it from article-newspaper and article-magazine, or add it to article-journal. Leaving it the way it is, is just inconsistent.

@agruber
Copy link
Contributor Author

agruber commented Jun 28, 2016

I have counted the number of CSL files that match the pattern 'variable="container-title".+text-case="title"'. Looks like there are 344 files with this expression. So that is a more general problem and needs to be address at a higher level. That could e.g. be done by checking the language field.

@adam3smith
Copy link
Member

CSL already checks the language field, which is why I don't consider it a problem for book titles and, for the most part, newspapers and magazines. The problem is that for journals, in particular, the language of the work doesn't necessarily match that of the journal title (historical German and Latin titles now publishing in English are probably the biggest group).

@agruber
Copy link
Contributor Author

agruber commented Jun 29, 2016

On the other way it will be wrong for all English journal names, which is by far the largest group.

@rmzelle
Copy link
Member

rmzelle commented Jul 2, 2016

On the other way it will be wrong for all English journal names

Well, that's only an issue when journal titles are (improperly) stored in lowercase in the metadata, right? In my experience with Zotero, I rarely encounter lowercased titles.

But I don't have a strong opinion either way (although I'm not a fan of title-casing, which is inherently lossy, and I don't think it should be encouraged; maybe the US/UK will get rid of it when they switch over to the metric system).

@adam3smith
Copy link
Member

n journal titles are (improperly) stored in lowercase in the metadata, right?

That's actually the core of the problem here: I used to think this was incorrect, but have since been told that technically speaking (i.e. by international cataloging standards), journal titles should be in sentence case and that's what Pubmed does. I believe we do title case journals for APA for that reason and so I think we might have to go that way, though I'm not liking it very much (obviously)

@rmzelle
Copy link
Member

rmzelle commented Jul 5, 2016

So we probably should title-case in the style, then?

@adam3smith
Copy link
Member

yeah -- let's. I'd still have been curious where the sentence cased journal titles came from, in particular for a sociology style, but the number of problematic journals in that field is equally small.

@adam3smith adam3smith merged commit bb928d5 into citation-style-language:master Jul 11, 2016
dschwilk pushed a commit to dschwilk/csl-styles that referenced this pull request Sep 7, 2016
…#2131)

Apply title case transformation to container-title in the else conditional that is called for article-journal. It is done so already for article-newspaper and article-magazine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants