Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between online video and movies #2112

Merged
merged 2 commits into from
Jun 17, 2016
Merged

Differentiate between online video and movies #2112

merged 2 commits into from
Jun 17, 2016

Conversation

joejoinerr
Copy link
Contributor

Creates different bibliography styles for online video or movies by querying the value of the URL field.

@csl-bot
Copy link

csl-bot commented Jun 17, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Jun 17, 2016

😃 Your submission passed all our automated tests.

@@ -56,6 +56,14 @@
<name initialize-with=". " name-as-sort-order="all" delimiter=", " delimiter-precedes-last="never" and="symbol"/>
</names>
</else-if>
<else-if type="motion_picture" variable="URL">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add match="all" here? It's the default so not technically necessary, but we find it avoids confusion

@adam3smith
Copy link
Member

Looks good otherwise, thanks!

@adam3smith adam3smith merged commit 2eb1afd into citation-style-language:master Jun 17, 2016
@adam3smith
Copy link
Member

thanks!

@csl-bot
Copy link

csl-bot commented Jun 17, 2016

😃 Your submission passed all our automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants