Update sist02.csl #1828
Update sist02.csl #1828
Conversation
I created this style about a year ago. It was my first time to create a new style with only one month of experience of using CSL Editor. After a year of experience, I am more comfortable with CSL and have updated this style. As a result, I have rewritten almost all the lines. I believe this code is much cleaner than the old one, with more sophisticated use of groups, delimiters, etc. .
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above. Then click the "View" button of the file you wish to change, and click on the pencil icon (see below) that appears in the next screen to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
|
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
| <text variable="container-title" suffix=". "/> | ||
| <if match="any" variable="container-title" type="webpage"> | ||
| <text term="open-quote"/> | ||
| <text variable="title" quotes="false"/> |
There was a problem hiding this comment.
why aren't you just doing quotes="true" here instead?
There was a problem hiding this comment.
Hi,
Thanks. I thought you would catch this. Let me explain.
What I am trying to get here is a title enclosed with quotes followed by a comma like below.
“TITLE”,
FYI, locales-ja-JP.xml has .
With the current coding, I can get the desired result in CSL Editor, Mendeley Desktop, and Word (see the attached sist02-1.png).
I added the section because locales-ja-JP.xml has Japanese parentheses 『 』.
“
”
…
When you use quotes="true", you get the desired result in CSL Editor but not in Mendeley Desktop or Word (see attached sist02-2.png).
“
”
…
I also tried the following, without the section this time, but again I get the desired result in CSL Editor but not in Mendeley Desktop or Word (see attached sist02-3.png).
Hope this explains the background of my coding.
Best regards,
Shoji
Shoji Takahashi
Solution Consultant (e-Platform and Content), A&G
Elsevier Japan KK
Tel: +81-3-5561-5994
Fax: +81-3-5561-0451
Address:
Higashi-Azabu 1-Chome Bldg. 4F
1-9-15 Higashi-Azabu, Minato-ku, Tokyo
106-0044 JAPAN
There was a problem hiding this comment.
I'll take a look best as I can in Mendeley, but unless I'm missing something, that's really something they need to fix. Your 2.) is the way to go and should work reliably.
There was a problem hiding this comment.
Thanks. Then, do you suggest that I would change the coding to 2) and then raise the problem with the Mendeley team?
Shoji
There was a problem hiding this comment.
I'd much prefer that, yes. I've double-checked 2.) in Zotero and it works correctly there, too. One possibility is that Mendeley is simply using an older version of citerproc-js, in which case this will fix itself, but would be good to check with them, yes. I'd much rather not have the workaround in the style, though.
There was a problem hiding this comment.
Thanks. I just submitted the change.
I looked at what I was doing in my old style and below is what I did there. I believe you (and I too) hate this!
Shoji
There was a problem hiding this comment.
that's right, I'm no fan of the hardcoded quotes at all, so this is much
better (it will also give you proper typographical curly quotes instead of
ugly straight ones).
On Sun, Dec 13, 2015 at 4:44 PM, Shoji Takahashi notifications@github.com
wrote:
In sist02.csl
#1828 (comment)
:<choose>
<if match="any" variable="container-title"><text variable="title" prefix=""" suffix="". "/><text variable="container-title" suffix=". "/><if match="any" variable="container-title" type="webpage"><text term="open-quote"/><text variable="title" quotes="false"/>Thanks. I just submitted the change. I looked at what I was doing in my
old style and below is what I did there. I believe you (and I too) hate
this! Shoji
From: Sebastian Karcher [mailto:notifications@github.com] Sent: Monday,
December 14, 2015 7:34 AM To: citation-style-language/styles Cc: Takahashi,
Shoji (ELS-TOK) Subject: Re: [styles] Update sist02.csl (#1828
#1828) In
sist02.csl<#1828 (comment)
#1828 (comment):
- - - + + +
I'd much prefer that, yes. I've double-checked 2.) in Zotero and it works
correctly there, too. One possibility is that Mendeley is simply using an
older version of citerproc-js, in which case this will fix itself, but
would be good to check with them, yes. I'd much rather not have the
workaround in the style, though. — Reply to this email directly or view it
on GitHub<
https://github.com/citation-style-language/styles/pull/1828/files#r47451593
.—
Reply to this email directly or view it on GitHub
https://github.com/citation-style-language/styles/pull/1828/files#r47451753
.
Sebastian Karcher, PhD
www.sebastiankarcher.com
|
indeed a big improvement, thanks! See two comments in line. |
|
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
|
thanks! |
I created this style about a year ago. It was my first time to create a new style with only one month of experience of using CSL Editor.
After a year of experience, I am more comfortable with CSL and have updated this style.
As a result, I have rewritten almost all the lines.
I believe this code is much cleaner than the old one, with more sophisticated use of groups, delimiters, etc.
.